Improve widgets alignment and size#8
Open
peransin-obeo wants to merge 3 commits into
Open
Conversation
Not editable widget must not be disabled. Disable widget cannot be scrolled. User should be able to read and copy the content. Actions must still be driven by "is Enabled Expression". eclipse-eef#3 Change-Id: I46b47a1ade5b3472191e619f07aa1c4db93adaa9 Signed-off-by: Nicolas Peransin <nicolas.peransin@obeo.fr>
Change-Id: I1b5a60b1307a09c91264a84bd78b5bd107526639
Remove extra borders. Align contents and action buttons. Same height for lists and multi references. Change-Id: Icecbef22336aeaf1817e82cff6fd8bafb8888b9a
lredor
reviewed
Jun 12, 2026
lredor
left a comment
lredor
left a comment
Contributor
There was a problem hiding this comment.
- The new behavior seems OK.
- Understanding what the numbers on the screenshots correspond to is not necessarily simple.
- The shift of some help tooltip seems strange. But after analysis, this is OK. It corresponds to fields that are in a container, so only the "labels/tooltips" of this container are "aligned".
| * Minimal height of the table widget. 5 Action buttons and almost 7 lines. | ||
| */ | ||
| private static final int TABLE_MINIMAL_HEIGHT = 150; | ||
| private static final int TABLE_MINIMAL_HEIGHT = 140; // same as AbstractEEFWidgetLifecycleManager |
Contributor
There was a problem hiding this comment.
I don't see what AbstractEEFWidgetLifecycleManager refers to. Perhaps you meant EEFListLifecycleManager?
Contributor
Contributor
There was a problem hiding this comment.
Yes, but I don't see "140" in AbstractEEFWidgetLifecycleManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test
test_resources.zip
Screen shot 1 Before patch
Screen shot 1 After patch
Screen shot 2 Before patch
Screen shot 2 After patch
